[gui-tests][full-ci] retry failed scenario #11920
Open
+122
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saw-jan
changed the title
saw-jan
force-pushed
the
tests/retry-failed-test
branch
3 times, most recently
from
d6df6e6
to
cc4ed54
Compare
saw-jan
changed the title
saw-jan
force-pushed
the
tests/retry-failed-test
branch
2 times, most recently
from
a93e55d
to
7161ffa
Compare
saw-jan
force-pushed
the
tests/retry-failed-test
branch
from
7161ffa
to
9a2b9bc
Compare
saw-jan
force-pushed
the
tests/retry-failed-test
branch
from
9a2b9bc
to
3b4d16e
Compare
ishabaral
reviewed
Oct 4, 2024
| @@ -73,12 +73,14 @@ def get_default_home_dir(): | |||
| 'clientConfigDir': 'CLIENT_CONFIG_DIR', | |||
| 'guiTestReportDir': 'GUI_TEST_REPORT_DIR', | |||
| 'ocis': 'OCIS', | |||
| 'screenRecordOnFailure': 'SCREEN_RECORD_ON_FAILURE', | |||
| 'recordVideoOnFailure': 'RECORD_VIDEO_ON_FAILURE', | |||
There was a problem hiding this comment.
how about writing these attributes in snake_case?
There was a problem hiding this comment.
would be great. but not in this PR.
| } | ||
|
|
||
| DEFAULT_PATH_CONFIG = { | ||
| 'custom_lib': os.path.abspath('../shared/scripts/custom_lib'), | ||
| 'home_dir': get_default_home_dir(), | ||
| # allow to record first 5 videos | ||
| 'videoRecordLimit': 5, |
There was a problem hiding this comment.
Suggested change
| 'videoRecordLimit': 5, | |
| 'video_record_limit': 5, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements retry failing test scenario.
Condition to trigger retry:
full-ciin the PR titileNote
--retryand--abortOnFailoptions clash with each other.So, we enable
--abortOnFailon normal PRand enable
--retryif above conditions are metWhat happens when retry is triggered?
Other changes:
SCREEN_RECORD_ON_FAILUREtoRECORD_VIDEO_ON_FAILUREscreenRecordOnFailuretorecordVideoOnFailurevideoRecordLimitto limit video recordings of failed scenarios -default: 5(because of large size)ReportHelperfile